Skip to content

[active_job] report on each retry failure #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
solnic merged 8 commits into from
May 2, 2025
Merged

[active_job] report on each retry failure #2598

solnic merged 8 commits into from
May 2, 2025

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Apr 14, 2025 •
edited
Loading

⚠️ this will increase error reporting rates - we may consider setting active_job_report_after_job_retries to true by default

Closes #2597

#skip-changelog

@solnic solnic marked this pull request as ready for review April 14, 2025 13:01
@solnic solnic requested review from sl0thentr0py and st0012 April 14, 2025 13:02
@getsentry getsentry deleted a comment from github-actions bot Apr 14, 2025
@solnic
Copy link
Collaborator Author

solnic commented Apr 14, 2025

Danger is still not seeing my changelog entry :(

@getsentry getsentry deleted a comment from github-actions bot Apr 15, 2025
@solnic solnic force-pushed the 2597-activejob-missing-error-reporting-on-retries branch from dff567f to 5d1cb20 Compare April 29, 2025 14:08
@solnic solnic marked this pull request as draft April 30, 2025 11:30
@solnic solnic mentioned this pull request Apr 30, 2025
Closed
@solnic solnic self-assigned this Apr 30, 2025
@solnic solnic marked this pull request as ready for review April 30, 2025 11:43
@solnic solnic changed the title [active_job] patch retry_job to report all errors during retries [active_job] report on each retry failure May 2, 2025
@solnic solnic merged commit 8c699de into master May 2, 2025
139 of 141 checks passed
@solnic solnic deleted the 2597-activejob-missing-error-reporting-on-retries branch May 2, 2025 19:18
solnic added a commit that referenced this pull request May 2, 2025
@solnic
Set active_job_report_after_job_retries to true by default
5b6a435 
Refs #2598
Refs #2597
@solnic solnic mentioned this pull request May 2, 2025
Closed
solnic added a commit that referenced this pull request May 5, 2025
@solnic
Set active_job_report_after_job_retries to true by default
328ec93 
Refs #2598
Refs #2597
@solnic solnic mentioned this pull request May 5, 2025
Merged
solnic added a commit that referenced this pull request May 8, 2025
@solnic
Introduce active_job_report_on_retry_error (#2617)
33d0b5d 
* Set active_job_report_after_job_retries to true by default

Refs #2598
Refs #2597

* Use test jobs defined in support file

* Introduce active_job_report_on_retry_error

* Fix spec

* Adjust spec skipping logic

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@st0012 st0012 Awaiting requested review from st0012

Assignees

@solnic solnic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActiveJob missing error reporting on retries

3 participants

@solnic @sl0thentr0py